Skip to content

Deduplicates some packages in yarn.lock #12512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fcollonval merged 1 commit into from
May 3, 2022
Merged

Deduplicates some packages in yarn.lock #12512

fcollonval merged 1 commit into from
May 3, 2022

Conversation

@fcollonval
Copy link
Member

@fcollonval fcollonval commented May 3, 2022

References

Some deduplication yarn did locally

Code changes

User-facing changes

N/A

Backwards-incompatible changes

N/A

@jupyterlab-probot
Copy link

jupyterlab-probot bot commented May 3, 2022

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@fcollonval fcollonval added this to the 4.0 milestone May 3, 2022
jtpio
jtpio approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio
Copy link
Member

jtpio commented May 3, 2022

Visual Regression Documentation failure is not related: #12340 (comment)

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2022

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

The mean relative comparison is computed with 95% confidence.

Results table
Test file large_code_notebook large_md_notebook
open
chromium
actual 11454 <- [11704 - 12118 - 12383] -> 12961 2344 <- [2429 - 2484 - 2543] -> 2711
expected 11427 <- [11658 - 12086 - 12367] -> 12829 2351 <- [2435 - 2485 - 2542] -> 2625
Mean relative change 0.3% ± 0.9% -0.0% ± 0.8%
switch-from
chromium
actual 503 <- [535 - 548 - 561] -> 584 395 <- [417 - 426 - 436] -> 996
expected 489 <- [529 - 542 - 554] -> 722 390 <- [420 - 431 - 438] -> 556
Mean relative change 0.8% ± 1.2% 0.4% ± 2.9%
switch-to
chromium
actual 298 <- [377 - 398 - 408] -> 439 252 <- [262 - 269 - 275] -> 294
expected 344 <- [376 - 398 - 409] -> 427 244 <- [266 - 271 - 279] -> 301
Mean relative change -0.1% ± 1.5% -0.9% ± 1.0%
close
chromium
actual 902 <- [946 - 958 - 971] -> 1009 413 <- [435 - 446 - 457] -> 475
expected 914 <- [946 - 960 - 968] -> 1019 405 <- [438 - 454 - 465] -> 478
Mean relative change -0.0% ± 0.6% -1.1% ± 1.0%

Changes are computed with expected as reference.

@fcollonval fcollonval merged commit a6f634e into jupyterlab:master May 3, 2022
@fcollonval fcollonval deleted the maitenance/dedup-yarn-lock branch May 3, 2022 14:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jtpio jtpio jtpio approved these changes

Assignees

@fcollonval fcollonval

Labels

maintenance

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@fcollonval @jtpio