Skip to content

Check-all checkbox should be unchecked when current directory is empty #12510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fcollonval merged 1 commit into from
May 4, 2022
Merged

Check-all checkbox should be unchecked when current directory is empty #12510

fcollonval merged 1 commit into from
May 4, 2022

Conversation

@gabalafou
Copy link
Contributor

@gabalafou gabalafou commented May 3, 2022

References

Fixes issue #12478.

Code changes

Fixes some logic (edge case error), adds regression test.

User-facing changes

See issue #12478.

Backwards-incompatible changes

Same as PR #12299.

@jupyterlab-probot
Copy link

jupyterlab-probot bot commented May 3, 2022

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@jtpio jtpio linked an issue May 3, 2022 that may be closed by this pull request
The file browser checkbox is checked by default when there is no file #12478
Closed
@jtpio jtpio added this to the 4.0 milestone May 3, 2022
@fcollonval
Copy link
Member

fcollonval commented May 4, 2022

Kicking the CI

@fcollonval fcollonval closed this May 4, 2022
@fcollonval fcollonval reopened this May 4, 2022
fcollonval
fcollonval approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gabalafou

CI failure is not related

@fcollonval fcollonval merged commit 3f53d10 into jupyterlab:master May 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2022

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

The mean relative comparison is computed with 95% confidence.

Results table
Test file large_code_notebook large_md_notebook
open
chromium
actual 17802 <- [18684 - 19208 - 19599] -> 21052 3150 <- [3383 - 3479 - 3572] -> 4006
expected 16966 <- [17978 - 18368 - 18959] -> 20855 3142 <- [3316 - 3393 - 3494] -> 3882
Mean relative change 3.5% ± 1.1% 1.9% ± 1.3%
switch-from
chromium
actual 712 <- [768 - 799 - 826] -> 1066 510 <- [560 - 582 - 608] -> 762
expected 691 <- [745 - 777 - 804] -> 1046 508 <- [550 - 572 - 598] -> 776
Mean relative change 2.5% ± 2.5% 1.0% ± 2.9%
switch-to
chromium
actual 449 <- [545 - 577 - 599] -> 660 334 <- [372 - 385 - 400] -> 446
expected 422 <- [531 - 564 - 589] -> 655 274 <- [367 - 383 - 400] -> 483
Mean relative change 2.0% ± 2.1% 0.7% ± 1.9%
close
chromium
actual 1268 <- [1348 - 1378 - 1409] -> 1507 566 <- [612 - 624 - 655] -> 793
expected 1261 <- [1333 - 1366 - 1402] -> 1535 560 <- [602 - 620 - 636] -> 733
Mean relative change 0.7% ± 1.1% 2.1% ± 1.6%

Changes are computed with expected as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees

@gabalafou gabalafou

Labels

enhancement pkg:filebrowser

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

The file browser checkbox is checked by default when there is no file

3 participants

@gabalafou @fcollonval @jtpio