Skip to content

Allow downstream extension to set toolbar layout #12499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jtpio merged 1 commit into from
May 2, 2022
Merged

Allow downstream extension to set toolbar layout #12499

jtpio merged 1 commit into from
May 2, 2022

Conversation

@fcollonval
Copy link
Member

@fcollonval fcollonval commented May 1, 2022

References

In cell toolbar extension, the specific toolbar layout is not playing nicely. This allows extension to reuse the toolbar class while providing a custom layout.

Code changes

Toolbar constructor now accepts a layout to override the default one.

User-facing changes

N/A

Backwards-incompatible changes

N/A

@jupyterlab-probot
Copy link

jupyterlab-probot bot commented May 1, 2022

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@fcollonval fcollonval added this to the 4.0 milestone May 1, 2022
jtpio
jtpio approved these changes May 2, 2022
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 6b79e85 into jupyterlab:master May 2, 2022
@fcollonval fcollonval deleted the ft/optional-toolbar-layout branch May 2, 2022 09:24
@fcollonval fcollonval modified the milestones: 4.0, 3.4.0 May 2, 2022
@fcollonval
Copy link
Member Author

fcollonval commented May 2, 2022

@meeseeksdev please backport to 3.4.x

@lumberbot-app
Copy link

lumberbot-app bot commented May 2, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 3.4.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 6b79e85a380a631c0b71d74162c041d8c175f0e7
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #12499: Allow downstream extension to set toolbar layout'
  1. Push to a named branch:
git push YOURFORK 3.4.x:auto-backport-of-pr-12499-on-3.4.x
  1. Create a PR against branch 3.4.x, I would have named this PR:

"Backport PR #12499 on branch 3.4.x (Allow downstream extension to set toolbar layout)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

fcollonval added a commit to fcollonval/jupyterlab that referenced this pull request May 2, 2022
@fcollonval
Backport PR jupyterlab#12499: Allow downstream extension to set toolb…
dea74e0 
…ar layout
@fcollonval fcollonval mentioned this pull request May 2, 2022
Merged
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2022

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

The mean relative comparison is computed with 95% confidence.

Results table
Test file large_code_notebook large_md_notebook
open
chromium
actual 13811 <- [14128 - 14230 - 14372] -> 15342 2590 <- [2716 - 2753 - 2788] -> 2882
expected 13619 <- [13789 - 13896 - 13979] -> 14646 2573 <- [2668 - 2703 - 2736] -> 2988
Mean relative change 2.9% ± 0.5% 1.8% ± 0.6%
switch-from
chromium
actual 579 <- [618 - 634 - 650] -> 679 431 <- [460 - 469 - 481] -> 530
expected 588 <- [611 - 622 - 635] -> 688 429 <- [451 - 461 - 471] -> 492
Mean relative change 1.7% ± 0.9% 2.4% ± 0.9%
switch-to
chromium
actual 395 <- [413 - 455 - 467] -> 487 280 <- [298 - 308 - 313] -> 343
expected 390 <- [415 - 452 - 462] -> 480 278 <- [299 - 302 - 310] -> 349
Mean relative change 0.7% ± 1.8% 0.8% ± 1.1%
close
chromium
actual 1065 <- [1099 - 1119 - 1136] -> 1186 478 <- [492 - 501 - 509] -> 533
expected 1062 <- [1082 - 1099 - 1117] -> 1178 473 <- [485 - 495 - 506] -> 524
Mean relative change 1.9% ± 0.7% 1.1% ± 0.7%

Changes are computed with expected as reference.

fcollonval added a commit that referenced this pull request May 2, 2022
@fcollonval
Backport PR #12499: Allow downstream extension to set toolbar layout (#…
96ae30d 
…12503)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jtpio jtpio jtpio approved these changes

Assignees

@fcollonval fcollonval

Labels

enhancement pkg:ui-components

Projects

None yet

Milestone

3.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@fcollonval @jtpio