Skip to content

Display default value in setting editor for changed values #12468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
echarles merged 1 commit into from
Apr 26, 2022
Merged

Display default value in setting editor for changed values #12468

echarles merged 1 commit into from
Apr 26, 2022

Conversation

@echarles
Copy link
Member

@echarles echarles commented Apr 25, 2022

References

Fixes #12284

Code changes

Show the default value in the settings editor for changed settings.

User-facing changes

Untitled4

Backwards-incompatible changes

None.

@jupyterlab-probot
Copy link

jupyterlab-probot bot commented Apr 25, 2022

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@github-actions github-actions bot added Design System CSS pkg:settingeditor tag:CSS For general CSS related issues and pecadilloes labels Apr 25, 2022
@fcollonval fcollonval added this to the 4.0 milestone Apr 26, 2022
fcollonval
fcollonval approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @echarles

@fcollonval
Copy link
Member

fcollonval commented Apr 26, 2022

CI failures are not related

@echarles echarles merged commit 4682f92 into jupyterlab:master Apr 26, 2022
@echarles
Copy link
Member Author

echarles commented Apr 26, 2022

Thx @fcollonval

@echarles
Copy link
Member Author

echarles commented Apr 26, 2022

@meeseeksdev please backport to 3.4.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Apr 26, 2022
@echarles @meeseeksmachine
Backport PR jupyterlab#12468: Display default value in setting editor…
a2fceb6 
… for changed values
@meeseeksmachine meeseeksmachine mentioned this pull request Apr 26, 2022
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2022

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

The mean relative comparison is computed with 95% confidence.

Results table
Test file large_code_notebook large_md_notebook
open
chromium
actual 16340 <- [16679 - 16883 - 17157] -> 17926 3090 <- [3213 - 3259 - 3328] -> 3791
expected 16027 <- [16384 - 16587 - 17124] -> 17923 3100 <- [3204 - 3237 - 3288] -> 3672
Mean relative change 1.1% ± 0.7% 1.2% ± 1.0%
switch-from
chromium
actual 673 <- [722 - 737 - 797] -> 1002 512 <- [548 - 559 - 587] -> 772
expected 649 <- [724 - 750 - 792] -> 1067 499 <- [543 - 559 - 588] -> 740
Mean relative change -0.5% ± 2.8% -0.0% ± 2.4%
switch-to
chromium
actual 482 <- [523 - 565 - 589] -> 665 335 <- [366 - 379 - 395] -> 468
expected 449 <- [522 - 566 - 601] -> 836 341 <- [358 - 369 - 386] -> 442
Mean relative change -0.7% ± 2.5% 2.1% ± 1.7%
close
chromium
actual 707 <- [1306 - 1345 - 1376] -> 1529 558 <- [608 - 626 - 644] -> 739
expected 745 <- [1308 - 1347 - 1395] -> 1522 573 <- [599 - 615 - 639] -> 700
Mean relative change -0.8% ± 1.8% 1.6% ± 1.5%

Changes are computed with expected as reference.

fcollonval pushed a commit that referenced this pull request Apr 26, 2022
@meeseeksmachine @echarles
Backport PR #12468: Display default value in setting editor for chang…
def3ddf 
…ed values (#12473)

Co-authored-by: Eric Charles <eric@datalayer.io>
@fcollonval fcollonval modified the milestones: 4.0, 3.4.0 Apr 29, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees

@echarles echarles

Labels

Design System CSS enhancement pkg:settingeditor tag:CSS For general CSS related issues and pecadilloes

Projects

None yet

Milestone

3.4.0

Development

Successfully merging this pull request may close these issues.

Settings editor should show default value

2 participants

@echarles @fcollonval