Skip to content

Use y-py 0.3.0 #12326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jtpio merged 2 commits into from
Apr 4, 2022
Merged

Use y-py 0.3.0 #12326

jtpio merged 2 commits into from
Apr 4, 2022

Conversation

@davidbrochart
Copy link
Contributor

@davidbrochart davidbrochart commented Apr 1, 2022

References

Supersedes #12320.

Code changes

Require y-py==0.3.0 and use its new API.

User-facing changes

None.

Backwards-incompatible changes

None.

@jupyterlab-probot
Copy link

jupyterlab-probot bot commented Apr 1, 2022

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@davidbrochart davidbrochart mentioned this pull request Apr 1, 2022
Closed
fcollonval
fcollonval approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davidbrochart

@davidbrochart davidbrochart marked this pull request as draft April 1, 2022 09:08
@davidbrochart davidbrochart marked this pull request as ready for review April 1, 2022 09:12
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2022

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

The mean relative comparison is computed with 95% confidence.

Results table
Test file large_code_notebook large_md_notebook
open
chromium
actual 3728 <- [3842 - 3906 - 3961] -> 4230 2478 <- [2553 - 2603 - 2670] -> 2902
expected 3736 <- [3835 - 3881 - 3941] -> 4145 2474 <- [2546 - 2589 - 2627] -> 2850
Mean relative change 0.3% ± 0.6% 1.1% ± 0.8%
switch-from
chromium
actual 655 <- [684 - 706 - 737] -> 932 485 <- [528 - 923 - 949] -> 1091
expected 646 <- [688 - 704 - 881] -> 982 483 <- [520 - 921 - 948] -> 1079
Mean relative change -3.3% ± 3.2% 3.0% ± 7.7%
switch-to
chromium
actual 321 <- [376 - 384 - 392] -> 470 257 <- [279 - 285 - 291] -> 314
expected 319 <- [375 - 381 - 387] -> 414 261 <- [277 - 285 - 293] -> 317
Mean relative change 0.7% ± 1.3% -0.3% ± 1.0%
close
chromium
actual 611 <- [917 - 930 - 949] -> 1020 455 <- [470 - 476 - 487] -> 518
expected 552 <- [916 - 927 - 938] -> 995 455 <- [473 - 478 - 487] -> 506
Mean relative change 2.4% ± 2.1% -0.2% ± 0.7%

Changes are computed with expected as reference.

@afshin afshin added dependencies Pull requests that update a dependency file maintenance labels Apr 1, 2022
@jtpio jtpio added this to the 4.0 milestone Apr 4, 2022
@jtpio
Copy link
Member

jtpio commented Apr 4, 2022

Thanks!

Looks like saving in the latest 4.0 pre-release (4.0.0a23) is currently broken, and this should fix it.

@jtpio jtpio mentioned this pull request Apr 4, 2022
Merged
7 tasks
@davidbrochart davidbrochart marked this pull request as draft April 4, 2022 08:10
@davidbrochart davidbrochart marked this pull request as ready for review April 4, 2022 08:59
@jtpio
Copy link
Member

jtpio commented Apr 4, 2022 •
edited
Loading

Just restarted the failed CI checks.

Expecting one failure for "Visual Regression Documentation", which will be fixed by #12337.

@jtpio
Copy link
Member

jtpio commented Apr 4, 2022

Expecting one failure for "Visual Regression Documentation",

Looks like that's the case:

image

So let's get this in, thanks!

@jtpio jtpio merged commit 5bddf7e into jupyterlab:master Apr 4, 2022
@davidbrochart davidbrochart deleted the ypy_0.3.0 branch April 4, 2022 12:58
@jtpio jtpio mentioned this pull request Apr 4, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees

@davidbrochart davidbrochart

Labels

dependencies Pull requests that update a dependency file maintenance

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@davidbrochart @jtpio @fcollonval @afshin