Skip to content

Allow ServerProcess.command to be a callable #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
manics merged 1 commit into from
Feb 25, 2025
Merged

Allow ServerProcess.command to be a callable #519

manics merged 1 commit into from
Feb 25, 2025

Conversation

@jwindgassen
Copy link
Contributor

@jwindgassen jwindgassen commented Feb 25, 2025

Resolves #518

@jhgoebbert jhgoebbert mentioned this pull request Feb 25, 2025
Closed
manics
manics approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll merge this now, but if you have time a test would make sure this mistake doesn't happen in future.

@manics manics merged commit b0c7feb into jupyterhub:main Feb 25, 2025
15 checks passed
@jwindgassen jwindgassen deleted the command-callable branch February 25, 2025 12:16
@jwindgassen jwindgassen mentioned this pull request Feb 25, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manics manics manics approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

callable arguments fail with TraitError(" .. instance expected a list, not the function")

2 participants

@jwindgassen @manics