Allow users to connect to services on other hosts #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuvipanda
requested changes
Aug 15, 2018
Contributor
yuvipanda
left a comment
yuvipanda
left a comment
There was a problem hiding this comment.
This is awesome!
However, I'd like us to implement a domain whitelist here. I'm mostly worried about things bypassing CORS through this.
Contributor
Author
|
@yuvipanda that sounds sensible! How do you recommend implementing this? Two options I can think of are:
|
Contributor
|
I'd suggest using traitlets backed by environment variables. github.com/jupyterhub/nbgitpuller is an example of how to do this. |
Contributor
|
I confirm the awesome. I just tested this out with Dask and it was success, with a tiny tweak. In our case we want to get to an IP, not a domain name. I swapped out the domain name for a really bad IP regex (I can make it better) and it worked. Could we make it handle IPs instead of just domain names too? |
Member
|
Closed by #154 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've come across situations where it would be useful to proxy to a port on a host other than
localhost.This PR adds an optional hostname option to the proxy url so users can specify things like:
The original format is still valid: