Skip to content

Work around incompatibility (missing firefox_profile arg) for acceptance tests #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
manics merged 1 commit into from
Jun 27, 2023
Merged

Work around incompatibility (missing firefox_profile arg) for acceptance tests #416

manics merged 1 commit into from
Jun 27, 2023

Conversation

@takluyver
Copy link
Member

@takluyver takluyver commented Jun 27, 2023

This will hopefully fix the CI failures looking like this:

tests/acceptance/test_acceptance.py::test_robot ==============================================================================
Acceptance :: Acceptance tests for jupyter-server-proxy                       
==============================================================================
Acceptance.Classic :: Server Proxies in Notebook Classic                      
==============================================================================
Notebook Classic Loads                                                | FAIL |
Parent suite setup failed:
TypeError: __init__() got an unexpected keyword argument 'firefox_profile'

robotframework/SeleniumLibrary#1836

@takluyver takluyver added the ci label Jun 27, 2023
@takluyver takluyver mentioned this pull request Jun 27, 2023
Merged
@manics manics merged commit da7e5f6 into jupyterhub:main Jun 27, 2023
@takluyver takluyver deleted the fix-selenium-error-acceptance-tests branch August 5, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manics manics manics approved these changes

Assignees

No one assigned

Labels

ci

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@takluyver @manics