Allow for other hosts than localhost to be proxied.
#128
Conversation
yuvipanda
left a comment
yuvipanda
left a comment
There was a problem hiding this comment.
Thanks for working on this!
I want to make sure that we only allow people to do this from subclassed hadnlers, and we make it so they explicitly are aware of the risks. I've left some comments, but will think a little more on how to make it harder to accidentally make this exploitable.
meant to be overridden.
|
@ian-r-rose this looks good to me! Unfortunately there are no tests :| Can you do a bunch of local testing to see if it works ok? Would be even better if you can add a quick test or two, but I understand if you don't want this to block on that. |
|
I've tested the I can try to add some tests this evening. |
|
I assume you also have some of extensions which it might be good to check with @yuvipanda? |
|
@ian-r-rose would <3 if you could add some simple tests :) |
|
I've added a very basic test, the great majority of the effort for which went into setting up the serverextension. |
|
Thanks for all the awesome work, @ian-r-rose! <3 |
2 participants
Finishes the work needed for #70, dask/dask-labextension#58.
This allows the developer to specify a non-localhost URI to be proxied. It should be a non-breaking change for users to
LocalProxyHandler. It seems to work well in my testing, but @yuvipanda and @ryanlovett have a much better idea of the range of places wherejupyter-server-proxyare deployed.