Skip to content

Conversation

@blink1073
Copy link
Contributor

This will fail until jupyter/notebook#6616 is merged and released

@blink1073
Copy link
Contributor Author

Hmm, tests/extension/test_serverextension.py::test_merge_config has started failing and I'm not sure why.

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.09%. Comparing base (f6b732c) to head (466f065).
Report is 305 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1064   +/-   ##
=======================================
  Coverage   73.09%   73.09%           
=======================================
  Files          64       64           
  Lines        8266     8266           
  Branches     1640     1640           
=======================================
  Hits         6042     6042           
  Misses       1819     1819           
  Partials      405      405           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blink1073
Copy link
Contributor Author

Oh, the test didn't fail because we weren't testing the tree handler before. Retrying with the notebook 7.0a8 release..

@blink1073
Copy link
Contributor Author

The order of precedence in jupyter_core 5.0 changed to what our tests had written as the expectation. 😅 Now the sys-prefix takes precedent over user inside a venv. I updated the test.

@blink1073 blink1073 merged commit d273e74 into jupyter-server:main Nov 11, 2022
@blink1073 blink1073 deleted the test-notebook-pre branch November 11, 2022 10:45
@blink1073
Copy link
Contributor Author

@meeseeksdev please backport to 1.x

@lumberbot-app
Copy link

lumberbot-app bot commented Nov 12, 2022

Oops, something went wrong applying the patch ... Please have a look at my logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants