Skip to content

Updated ui-tests Configuration in Contributing.md #7124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jtpio merged 5 commits into from
Oct 27, 2023
Merged

Updated ui-tests Configuration in Contributing.md #7124

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
18a9efb
Updated ui-tests Configuration in Contributing.md
jayeshsingh9767 Oct 23, 2023
50005f8
Merge branch 'main' into update_contributing_doc
jayeshsingh9767 Oct 23, 2023
5ab11ab
Replaced npx with jlpm
jayeshsingh9767 Oct 27, 2023
d8272c5
Merge branch 'update_contributing_doc' of github.com-private:jayeshsi…
jayeshsingh9767 Oct 27, 2023
4260a04
Merge branch 'main' into update_contributing_doc
jtpio Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Updated ui-tests Configuration in Contributing.md
  • Loading branch information
@jayeshsingh9767
jayeshsingh9767 committed Oct 23, 2023
commit 18a9efb52ca2bac36f721b439ee73d54a291478c
6 changes: 6 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,12 @@ There are also end to end tests to cover higher level user interactions, located

```bash
cd ui-tests
#install required packages for jlpm
jlpm

#install playwright
npx playwright install
Copy link
Member

@jtpio jtpio Oct 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can stick to jlpm for consistency here?

Suggested change
npx playwright install
jlpm playwright install

Copy link
Contributor Author

@jayeshsingh9767 jayeshsingh9767 Oct 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jtpio for pointing out.


# start a new Jupyter server in a terminal
jlpm start

Expand Down