Skip to content

Fix the redirect handler #6941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jtpio merged 1 commit into from
Jun 22, 2023
Merged

Fix the redirect handler #6941

jtpio merged 1 commit into from
Jun 22, 2023

Conversation

@jtpio
Copy link
Member

@jtpio jtpio commented Jun 22, 2023

Fixes #6940

@balajialg trying locally with jupyterhub with the following config, it looks like this should fix the issue

c = get_config()  # noqa

from jupyterhub.auth import DummyAuthenticator

c.JupyterHub.authenticator_class = DummyAuthenticator

from jupyterhub.spawner import SimpleLocalProcessSpawner

c.JupyterHub.spawner_class = SimpleLocalProcessSpawner
c.JupyterHub.bind_url = 'http://0.0.0.0:8000'
c.Spawner.cmd = ["jupyter-labhub"]
c.Spawner.default_url = '/tree'

Before

jupyterhub-redirect-issue.mp4

After

jupyterhub-redirect.mp4

@github-actions
Copy link
Contributor

github-actions bot commented Jun 22, 2023

Binder 👈 Launch a Binder on branch jtpio/notebook/redirects

@jtpio jtpio added the bug label Jun 22, 2023
@jtpio jtpio added this to the 7.0 milestone Jun 22, 2023
@jtpio jtpio marked this pull request as ready for review June 22, 2023 07:27
@jtpio
Copy link
Member Author

jtpio commented Jun 22, 2023

Getting that one in and following-up with a release since it seems to be fixing #6940

@jtpio jtpio merged commit 8493e1b into jupyter:main Jun 22, 2023
@jtpio jtpio deleted the redirects branch June 22, 2023 08:40
@jtpio jtpio mentioned this pull request Jun 22, 2023
Closed
@jtpio jtpio mentioned this pull request Jul 18, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@jtpio jtpio

Labels

bug

Projects

None yet

Milestone

7.0

Development

Successfully merging this pull request may close these issues.

Corrupted URL when upgraded to Jupyter Notebook version 7.0.0rc0 and Jupyter Lab version 4.0.2

1 participant

@jtpio