Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Mar 29, 2023

Fixes a part of #6785 - Text editor should display a partial view.
New view:
Screen Shot 2023-03-29 at 11 26 00 AM

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch j-publius/jupyternotebookfork/add-bottom-spacer

@github-actions github-actions bot assigned ghost Mar 29, 2023
{% endblock %}
</head>
<body>
<body data-edit="edit">
Copy link
Author

@ghost ghost Mar 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My reasoning for doing it this way is that the notebook template has an attribute just like this. It is only ever referenced in this and this CSS file for the purposes of styling.

This allows me to target exclusively edit pages to add the spacer at the bottom.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case maybe it should be for consistency:

Suggested change
<body data-edit="edit">
<body data-notebook="edit">

@ghost ghost marked this pull request as draft March 29, 2023 01:24
@ghost ghost closed this Mar 29, 2023
@ghost ghost reopened this Mar 29, 2023
@ghost ghost marked this pull request as ready for review March 29, 2023 01:29
@jtpio jtpio added the bug label Mar 29, 2023
@jtpio jtpio added this to the 7.0 milestone Mar 29, 2023
@jtpio
Copy link
Member

jtpio commented Mar 29, 2023

Thanks @j-publius for working on this 👍

Would you mind adding a screenshot to the top comment to get an idea of what it looks like?

@ghost
Copy link
Author

ghost commented Mar 29, 2023

Thanks @j-publius for working on this 👍

Would you mind adding a screenshot to the top comment to get an idea of what it looks like?

Added + updated attribute value for consistency

@jtpio jtpio mentioned this pull request Mar 30, 2023
5 tasks
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 9355169 into jupyter:main Mar 30, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant