Fix JSON setting editor not opening issue #6795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
yumyumqing
changed the title
jtpio
approved these changes
Mar 24, 2023
Member
jtpio
left a comment
jtpio
left a comment
There was a problem hiding this comment.
Thanks!
This looks good when testing the PR on Binder: https://mybinder.org/v2/gh/yumyumqing/notebook/fix-setting-widget?urlpath=tree
advanced-settings-editor.mp4
Member
|
@yumyumqing I think we can mark the PR as ready and merge it if that's ok for you? Just wanted to make sure first in case you wanted to make more changes, but it looks good like this 👍 |
Contributor
Author
|
Yes thanks @jtpio ! I don't have anything else to add. I have marked it as ready and feel free to merge it now. Thanks again for your help on this! |
Member
|
Thanks again! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue: #6778