Skip to content

Fix loading of plugins #6750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jtpio merged 12 commits into from
Feb 27, 2023
Merged

Fix loading of plugins #6750

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
669f5e7
Explicit load plugins for the settings editor
jtpio Feb 25, 2023
997840b
Move logic to the tree extension
jtpio Feb 25, 2023
df08d97
Move logic to a separate plugin
jtpio Feb 25, 2023
8f820a6
Read extensions in webpack config
jtpio Feb 25, 2023
98afd6e
Rearrange package.json
jtpio Feb 25, 2023
a9f115e
read mime extensions
jtpio Feb 26, 2023
6e63523
Template plugins per page
jtpio Feb 26, 2023
d12bacd
Cleanup
jtpio Feb 26, 2023
7589fd1
Load allPlugins for the settings editor
jtpio Feb 26, 2023
839f0c9
Expand on the comment
jtpio Feb 26, 2023
fd16e7b
Expand on comment
jtpio Feb 27, 2023
c824ef0
Fix lint
jtpio Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Cleanup
  • Loading branch information
@jtpio
jtpio committed Feb 26, 2023
commit d12bacdba04a8b77cde808547e08522db4316c9c
4 changes: 0 additions & 4 deletions app/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,6 @@ async function createModule(scope, module) {
* The main function
*/
async function main() {
// load extra packages
// TODO: check if stil needed
require('@jupyterlab/celltags');

const mimeExtensionsMods = [
{{#each notebook_mime_extensions}}
require('{{ @key }}'),
Expand Down
4 changes: 2 additions & 2 deletions packages/tree-extension/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import {
IDefaultFileBrowser
} from '@jupyterlab/filebrowser';

import { ISettingRegistry, SettingRegistry } from '@jupyterlab/settingregistry';
import { ISettingRegistry } from '@jupyterlab/settingregistry';

import { IRunningSessionManagers, RunningSessions } from '@jupyterlab/running';

Expand Down Expand Up @@ -236,7 +236,7 @@ const notebookTreeWidget: JupyterFrontEndPlugin<INotebookTree> = {
app.shell.add(nbTreeWidget, 'main', { rank: 100 });

if (settingEditorTracker) {
settingEditorTracker.widgetAdded.connect(async (_, editor) => {
settingEditorTracker.widgetAdded.connect((_, editor) => {
nbTreeWidget.addWidget(editor);
nbTreeWidget.tabBar.addTab(editor.title);
nbTreeWidget.currentWidget = editor;
Expand Down