Skip to content

Update to JupyterLab 4.0.0a31 #6627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jtpio merged 15 commits into from
Nov 21, 2022
Merged

Update to JupyterLab 4.0.0a31 #6627

jtpio merged 15 commits into from
Nov 21, 2022

Conversation

@jtpio
Copy link
Member

@jtpio jtpio commented Nov 18, 2022 •
edited
Loading

Fixes #6577

toc-failure.mp4

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2022

Binder 👈 Launch a Binder on branch jtpio/notebook/update-latest-lab

@jtpio jtpio added this to the 7.0 milestone Nov 18, 2022
@jtpio jtpio linked an issue Nov 18, 2022 that may be closed by this pull request
Running Panel sections not accessible at browser zoom #6559
Closed
@fcollonval
Copy link
Collaborator

fcollonval commented Nov 18, 2022

FYI about the notification feature - I have a draft (locally) to extract it to link the view to any widget (not necessarily the one of the status widget as in JupyterLab). I hit a refactoring trouble due to typestyle. We definitely should get ride of it (except maybe for LabIcon - the use case is quite advanced). Then it will be easy to refactor the code to provide a notification view in ui-components that you can anchor on any widget that is adequate for the notebook v7 UI.

jtpio
jtpio commented Nov 18, 2022
View reviewed changes
pyproject.toml
"pytest-console-scripts",
"ipykernel",
"jupyterlab_server[test]>=2.13,<3",
"jupyter_server[test]>=2.0.0rc3,<3",
Copy link
Member Author

@jtpio jtpio Nov 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addition seems to be necessary to fix jupyterlab/jupyterlab#13438 (probably related to the pre-release).

@jtpio
Copy link
Member Author

jtpio commented Nov 18, 2022

FYI about the notification feature

Nice thanks for the heads-up!

We definitely should get ride of it

👍

Happy to track that in a follow-up issue.

@jtpio
Copy link
Member Author

jtpio commented Nov 18, 2022

Fix UI tests for the Table of Contents

Thanks @brichet for adding UI tests for the TOC which helped catch this issue! (and fix it with 47b0c4f)

@jtpio jtpio marked this pull request as ready for review November 18, 2022 14:58
@jtpio jtpio merged commit e4b91ec into jupyter:main Nov 21, 2022
@jtpio jtpio deleted the update-latest-lab branch November 21, 2022 07:32
@echarles echarles mentioned this pull request Nov 23, 2022
Closed
@fcollonval fcollonval mentioned this pull request Dec 13, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

7.0

Development

Successfully merging this pull request may close these issues.

Update to JupyterLab 4.0.0a31 Running Panel sections not accessible at browser zoom

2 participants

@jtpio @fcollonval