Skip to content

Bump to Python 3.11 on CI #6600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jtpio merged 3 commits into from
Nov 16, 2022
Merged

Bump to Python 3.11 on CI #6600

jtpio merged 3 commits into from
Nov 16, 2022

Conversation

@jtpio
Copy link
Member

@jtpio jtpio commented Oct 25, 2022

Update CI to use the latest Python version.

@jtpio jtpio added this to the 7.0 milestone Oct 25, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2022

Binder 👈 Launch a Binder on branch jtpio/notebook/python-311

@fcollonval
Copy link
Collaborator

fcollonval commented Oct 27, 2022

@jtpio this is gonna break because there is no binary for y-py supporting 3.11

@jtpio
Copy link
Member Author

jtpio commented Oct 27, 2022

@jtpio this is gonna break because there is no binary for y-py supporting 3.11

Isn't it already breaking regardless of whether 3.11 is tested on CI?

@jtpio
Copy link
Member Author

jtpio commented Oct 27, 2022

The 3.11 install checks are passing though: https://github.com/jupyter/notebook/actions/runs/3335770429/jobs/5520203591

@fcollonval
Copy link
Collaborator

fcollonval commented Oct 27, 2022

Nice the GitHub image can by default built python + rust package:

  🔗 Found pyo3 bindings
  🐍 Found CPython 3.11 at /opt/hostedtoolcache/Python/3.11.0/x64/bin/python
  y_py-0.5.4.dist-info
  Checking for Rust toolchain....
  Running `maturin pep517 write-dist-info --metadata-directory /tmp/pip-modern-metadata-41g6zxbn --interpreter /opt/hostedtoolcache/Python/3.11.0/x64/bin/python`
  Preparing metadata (pyproject.toml): finished with status 'done'
  Source in /tmp/pip-install-tbo9dzu8/y-py_649ec4f9cdee47e3849d8f101a67a9fc has version 0.5.4, which satisfies requirement y-py<0.6.0,>=0.5.3 from https://files.pythonhosted.org/packages/3e/19/59895b6e4a4f191142a96a655a94b1b5396c54270097db97b83014b0c958/y_py-0.5.4.tar.gz (from jupyter-ydoc<0.3.0,>=0.2.0->jupyterlab<5,>=4.0.0a30->notebook==7.0.0a7)

@jtpio
Copy link
Member Author

jtpio commented Oct 27, 2022

no binary for y-py supporting 3.11

This is tracked in y-crdt/ypy#82

@jtpio jtpio marked this pull request as ready for review November 16, 2022 09:22
@jtpio
Copy link
Member Author

jtpio commented Nov 16, 2022

CI is passing. Hopefully we can rely on GitHub Actions being able to build from source while waiting for y-crdt/ypy#82.

Opened #6622 as a follow-up (noticed while doing this update).

@jtpio jtpio merged commit 58823f0 into jupyter:main Nov 16, 2022
@jtpio jtpio deleted the python-311 branch November 16, 2022 09:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

maintenance

Projects

None yet

Milestone

7.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jtpio @fcollonval