Skip to content

Fix HTML viewer #6583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jtpio merged 1 commit into from
Oct 17, 2022
Merged

Fix HTML viewer #6583

jtpio merged 1 commit into from
Oct 17, 2022

Conversation

@brichet
Copy link
Collaborator

@brichet brichet commented Oct 17, 2022

This PR fix HTML viewer by adding the dependency in notebook/app.

Related to #6582

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2022

Binder 👈 Launch a Binder on branch brichet/notebook/fix/HTMLviewer

@jtpio jtpio added the bug label Oct 17, 2022
@jtpio jtpio added this to the 7.0 milestone Oct 17, 2022
jtpio
jtpio approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 8412694 into jupyter:main Oct 17, 2022
@brichet brichet deleted the fix/HTMLviewer branch October 17, 2022 12:46
@jtpio jtpio mentioned this pull request Oct 17, 2022
Closed
@brichet brichet mentioned this pull request Oct 26, 2022
Merged
2 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jtpio jtpio jtpio approved these changes

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

7.0

Development

Successfully merging this pull request may close these issues.

2 participants

@brichet @jtpio