Skip to content

Update to lerna 6 #6579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jtpio merged 6 commits into from
Oct 20, 2022
Merged

Update to lerna 6 #6579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
13fe21b
Update to lerna 6
jtpio Oct 15, 2022
eedfc74
Run `build:utils` before bumping
jtpio Oct 17, 2022
89c9e7e
Move releaser config to pyproject.toml
jtpio Oct 17, 2022
cf6dc5f
Update hooks
jtpio Oct 19, 2022
db32b7e
Try disabling nx
jtpio Oct 20, 2022
769f9a9
Remove debug line
jtpio Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,6 @@
"fs-extra": "^8.1.0",
"glob": "~7.1.6",
"mini-css-extract-plugin": "~0.9.0",
"npm-run-all": "^4.1.5",
"rimraf": "^3.0.2",
"style-loader": "~1.0.1",
"svg-url-loader": "~6.0.0",
Expand Down
1 change: 1 addition & 0 deletions lerna.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"npmClient": "yarn",
"useNx": false,
Copy link
Member Author

@jtpio jtpio Oct 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems required for now as it seems to be breaking the releaser check-npm step currently.

Will track that in a different issue.

"version": "independent",
"useWorkspaces": true
}
21 changes: 2 additions & 19 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
"build": "lerna run build",
"build:prod": "lerna run build:prod",
"build:test": "lerna run build:test",
"build:utils": "cd buildutils && npm run build",
"clean": "lerna run clean",
"develop": "jupyter labextension develop . --overwrite && node ./buildutils/lib/develop.js --overwrite",
"eslint": "eslint . --ext .ts,.tsx --fix",
Expand Down Expand Up @@ -55,27 +56,9 @@
"jest-junit": "^11.1.0",
"jest-raw-loader": "^1.0.1",
"jest-summary-reporter": "^0.0.2",
"lerna": "^5.5.0",
"npm-run-all": "^4.1.5",
"lerna": "^6.0.1",
"prettier": "^1.19.0",
"rimraf": "^3.0.2",
"typescript": "~4.7.3"
},
"jupyter-releaser": {
"hooks": {
"before-build-npm": [
"jlpm clean",
"jlpm build:prod"
],
"before-build-python": [
"jlpm clean"
],
"before-bump-version": "python -m pip install hatch"
},
"options": {
"version-cmd": [
"jlpm run release:bump --force --skip-commit"
]
}
}
}
17 changes: 17 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,3 +141,20 @@ extend-ignore = [
# black adds spaces around ':'
"E203",
]

[tool.jupyter-releaser.options]
version-cmd = "jlpm run release:bump --force --skip-commit"

[tool.jupyter-releaser.hooks]
before-bump-version = [
"python -m pip install --pre -U jupyterlab",
"jlpm",
"jlpm run build:utils",
"python -m pip install hatch"
]
before-build-npm = [
"jlpm build:prod"
]
before-build-python = [
"jlpm clean"
]
Loading