Skip to content

Conversation

@jtpio
Copy link
Member

@jtpio jtpio commented Sep 2, 2022

Updating @playwright/test to a newer version.

@jtpio jtpio marked this pull request as draft September 2, 2022 13:31
@jtpio jtpio added this to the 7.0 milestone Sep 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

Binder 👈 Launch a Binder on branch jtpio/notebook/update-playwright

@jtpio
Copy link
Member Author

jtpio commented Sep 2, 2022

The global config in playwright.config.ts does not seem to be taken into account anymore:

use: {
appPath: ''
},

Which means it's redirecting to /lab/tree instead. Overriding with test.use() locally in the test file works though.

@jtpio
Copy link
Member Author

jtpio commented Sep 28, 2022

Putting this one on hold for now.

A fix was submitted and merged upstream in jupyterlab/jupyterlab#13140.

Waiting for #6539 to get in first.

@jtpio jtpio closed this in #6539 Oct 3, 2022
@jtpio jtpio deleted the update-playwright branch May 16, 2023 08:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant