Skip to content

Conversation

@jtpio
Copy link
Member

@jtpio jtpio commented Apr 19, 2022

This should fix #6347

There was some syntax errors in the workflow that prevented the check to run on CI.

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jtpio/notebook/fix-ci

@jtpio jtpio added this to the 7.0 milestone Apr 19, 2022
@jtpio
Copy link
Member Author

jtpio commented Apr 20, 2022

Tests pass locally but CI fails here:

shutil.copytree(src, dst)

Doesn't seem to find the jupyterlab_server test data:

image

@jtpio
Copy link
Member Author

jtpio commented Apr 20, 2022

Doesn't seem to find the jupyterlab_server test data:

This seems to be fixed by using Python 3.10 on CI in c5f24f7 (same version as used locally).

cc @blink1073 since this might affect other projects using jupyterlab_server.test_data in their tests.

@jtpio
Copy link
Member Author

jtpio commented Apr 20, 2022

CI all green with the build workflows running again.

@jtpio jtpio merged commit 793dc95 into jupyter:main Apr 20, 2022
@jtpio jtpio deleted the fix-ci branch April 20, 2022 07:50
@blink1073
Copy link
Contributor

cc @blink1073 since this might affect other projects using jupyterlab_server.test_data in their tests.

That's odd, thanks for the heads up!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build CI workflow does not run on main

2 participants