Initialize handler page_config from Server traitlets #6366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
Member
|
Thanks! Looks like this adds the following two items to the File menu (noticed by the UI tests):
Which is fine. We can always re-work the snapshots later via the settings system so they look more like the ones from the classic notebook:
|
Contributor
Author
|
Thanks! |
This was referenced Apr 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This initializes
page_configfrom, e.g.ServerApp.tornado_settings.page_config_data. These values can be subsequently overwritten by other configurables.This corresponds to
LabHandlerin jupyterlab_server.