Skip to content

handle KeyError when get session #6245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kevin-bates merged 2 commits into from
Dec 20, 2021
Merged

handle KeyError when get session #6245

kevin-bates merged 2 commits into from
Dec 20, 2021

Conversation

@ccw630
Copy link
Contributor

@ccw630 ccw630 commented Dec 9, 2021

If gateway is enabled, row_to_model can delete session row when kernel culled or died on gateway. Then it raises a KeyError unhadled in get_session.

kevin-bates
kevin-bates approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you.

@ccw630
Copy link
Contributor Author

ccw630 commented Dec 10, 2021

Wondering if I should make a same PR to repo jupyter_server - what's the diffrence between those backend code?

@kevin-bates
Copy link
Member

kevin-bates commented Dec 10, 2021

Yes, that would be helpful, thank you.
Jupyter server was derived directly from notebook but only includes backend code. That is, it is only the server portion.
The notebook repository is essentially in a maintenance-only mode while jupyter_server entertains feature additions, etc. Front-end applications have or are migrating to jupyter_server.

@ccw630 ccw630 mentioned this pull request Dec 14, 2021
Merged
@kevin-bates kevin-bates merged commit 46f40e7 into jupyter:master Dec 20, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@kevin-bates kevin-bates kevin-bates approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status:resolved-locked

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ccw630 @kevin-bates