Skip to content

Add missing "import inspect" #5999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Zsailer merged 1 commit into from
Mar 3, 2021
Merged

Add missing "import inspect" #5999

Zsailer merged 1 commit into from
Mar 3, 2021

Conversation

@mgeier
Copy link
Contributor

@mgeier mgeier commented Mar 3, 2021

I got an error when running the master branch of notebook:

[W 15:12:59.786 NotebookApp] Error loading config file: jupyter_notebook_config
    Traceback (most recent call last):
...
      File "/home/[...]/notebook/notebookapp.py", line 1402, in _observe_contents_manager_class
        if inspect.isclass(new):
    NameError: name 'inspect' is not defined

I don't know why the import is missing how this hasn't been detected by CI, but adding the import statement seems to fix the error/warning.

@Zsailer
Copy link
Member

Zsailer commented Mar 3, 2021

Yikes, good catch, @mgeier. Thank you.

@Zsailer Zsailer merged commit dc8b705 into jupyter:master Mar 3, 2021
@mgeier mgeier deleted the import-inspect branch March 3, 2021 17:57
@blink1073 blink1073 added this to the 6.3 milestone Mar 18, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Zsailer Zsailer Zsailer approved these changes

Assignees

No one assigned

Labels

status:resolved-locked

Projects

None yet

Milestone

6.3

Development

Successfully merging this pull request may close these issues.

3 participants

@mgeier @Zsailer @blink1073