Skip to content

Drop use of deprecated pyzmq.ioloop #5965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Zsailer merged 1 commit into from
Jan 29, 2021
Merged

Drop use of deprecated pyzmq.ioloop #5965

Zsailer merged 1 commit into from
Jan 29, 2021

Conversation

@kevin-bates
Copy link
Member

@kevin-bates kevin-bates commented Jan 28, 2021

Now that we require pyzmq > 17 (and have for a few years) we can drop its ioloop and use tornado's. This will remove another deprecation message...

notebook\notebookapp.py:50
  D:\a\notebook\notebook\notebook\notebookapp.py:50: DeprecationWarning: zmq.eventloop.ioloop is deprecated in pyzmq 17. pyzmq now works with default tornado and asyncio eventloops.
    ioloop.install()

@Zsailer Zsailer merged commit 5c081a3 into jupyter:master Jan 29, 2021
@kevin-bates kevin-bates deleted the drop-pyzmq-ioloop branch January 29, 2021 23:40
@blink1073 blink1073 added this to the 6.3 milestone Mar 18, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Zsailer Zsailer Zsailer approved these changes

Assignees

No one assigned

Labels

status:resolved-locked

Projects

None yet

Milestone

6.3

Development

Successfully merging this pull request may close these issues.

3 participants

@kevin-bates @Zsailer @blink1073