Require a file name in the "Save As" dialog #5733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-bates
approved these changes
Sep 5, 2020
Member
kevin-bates
left a comment
kevin-bates
left a comment
There was a problem hiding this comment.
This tests out great - thank you. I'm going to ask another maintainer to review the changes.
Member
|
Steve, I'm hoping you can take a look at the changes. They test out fine on my end. Thank you. |
blink1073
approved these changes
Sep 8, 2020
Contributor
blink1073
left a comment
blink1073
left a comment
There was a problem hiding this comment.
Looks reasonable to me, thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #5732 by checking for empty file names in the "Save As" dialog and refusing to save the file. It also helpfully highlights the instructions to the user in red.
It would be better if the error message were clearer, or even better if the save button were disabled until a file name was entered, but that would require a much larger and more complex change to the code. (Maintainers, feel free to take this patch and run with it!)