Skip to content

Conversation

@Nishikoh
Copy link
Contributor

Fix #5599
The links to the Project Jupyter Contributor Documentation and Project Jupyter Documentation Guide is broken.
Fixed them.

The link to the `Project Jupyter Documentation Guide` is broken.
Fixed it links.
CONTRIBUTING.rst Outdated
You should also have a look at the `Project Jupyter Documentation Guide`__.

__ https://jupyter.readthedocs.io/en/latest/contrib_docs/index.html
__ https://jupyter.readthedocs.io/en/latest/contributing/content-contributor.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nishikoh - thank you for this contribution!

I think the intention of this link is to point to the documentation guide, which appears to be here: https://jupyter.readthedocs.io/en/latest/contributing/docs-contributions/index.html

Once updated, I'd be happy to merge. Thank you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review! Fixed it :D

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kevin-bates kevin-bates merged commit b8b5468 into jupyter:master Jul 11, 2020
@Nishikoh Nishikoh deleted the Fix-broken-link branch July 11, 2020 17:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A couple links to Jupyter documentation from README are broken

2 participants