Integrated LoginWidget into edit to enable users to logout from the t… #5406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ext edit view. Issue jupyter#5399
kevin-bates
approved these changes
Apr 28, 2020
Member
kevin-bates
left a comment
kevin-bates
left a comment
There was a problem hiding this comment.
These changes LGTM and the functionality appears sufficient. I'm hoping someone with some NB front-end experience and double-check the source changes in case there's something I don't know to look for. If no one swings by in the next couple days, I'll go ahead and merge.
Thank you @jpcastil!
Contributor
Author
|
Hey @kevin-bates! Were you able to merge it? Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ext edit view. Issue #5399