Skip to content

Code refactoring notebook.js #5352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Zsailer merged 3 commits into from
May 18, 2020
Merged

Code refactoring notebook.js #5352

Zsailer merged 3 commits into from
May 18, 2020

Conversation

@ErwinRussel
Copy link
Contributor

@ErwinRussel ErwinRussel commented Apr 8, 2020 •
edited
Loading

Refactored duplicate code in notebook.js. Transforming a cell to raw or markdown takes use of a single method.

@ErwinRussel ErwinRussel changed the title [WIP] code refactoring Code refactoring notebook.js Apr 8, 2020
Zsailer
Zsailer approved these changes May 18, 2020
View reviewed changes
Copy link
Member

@Zsailer Zsailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @ErwinRussel

@Zsailer Zsailer merged commit ae7747f into jupyter:master May 18, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Zsailer Zsailer Zsailer approved these changes

Assignees

No one assigned

Labels

status:resolved-locked

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ErwinRussel @Zsailer