Make a notebook writable after successful save-as #5296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toonijn
force-pushed
the
save_as_readonly
branch
from
b740207 to
03e2698
Compare
kevin-bates
reviewed
May 5, 2020
| # even after a refresh | ||
| refresh_notebook(notebook) | ||
| assert notebook.get_cell_contents(index=0) == test_content_0 | ||
| assert notebook.get_cell_contents(index=1) == test_content_1 No newline at end of file |
kevin-bates
approved these changes
May 5, 2020
Member
kevin-bates
left a comment
kevin-bates
left a comment
There was a problem hiding this comment.
These changes look good to me, but I don't have the front-end knowledge to know if this introduces any issues or side-effects. Hoping we can find a reviewer in this area soon.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1324.
When edits were made in a read-only notebook there was no way to preserve these changes.
(See also Stack Overflow: How to save changes in read-only Jupyter Notebook)