Don't trash non-empty directories on Windows #3673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that the Windows backend of send2trash can't guarantee that files won't actually be deleted. There are some hints that this happens in particular when you delete a lot of data at once. So this returns to refusing to delete folders unless they're empty (or contain only ipynb checkpoints). Closes jupytergh-3631
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that the Windows backend of send2trash can't guarantee that files won't actually be deleted. There are some hints that this happens in particular when you delete a lot of data at once. So this returns to refusing to delete folders unless they're empty (or contain only ipynb checkpoints).
Closes gh-3631