Add a output_updated.OutputArea event #3560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks, looks good to me. I'll give @rgbkrk a chance to look at it before I merge, since he has an interest in the rich display machinery. |
Member
|
Sweet, love to have a nice small PR introducing a single event. |
rgbkrk
approved these changes
Apr 24, 2018
Member
|
Tada! Thank you @philippjfr for your contribution. 🍪 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in #3557 this PR adds a
output_updated.OutputAreaevent, triggered byupdate_display_datamessages, to match the existingoutput_added.OutputAreaevent which is triggered whenexecute_resultanddisplay_datamessages are received. Like theoutput_addedevent this allows registering callbacks which are given the entire mime bundle and the OutputArea, matching the capability of JupyterLab MIME renderers which are also given the entire mime bundle whenupdate_display_datamessages are received.Let me know if there is some place to document this new event and/or add some kind of test for it (couldn't find either in a cursory search). As an aside, very happy about my first ever contribution to the notebook.