[WIP] [3335] Convert JS tests to Selenium #3551
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge from main jupyter/notebook
Member
|
Thanks, this looks OK to me. If you're happy that you've got everything from the JS test you were converting, please go ahead and remove it. :-) |
Contributor
Author
|
Filed new PR 3554 after removing prompt_numbers.js test |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to contribute to converting JS tests to selenium tests. This patch is for converting notebook/prompt_numbers.js to selenium/test_prompt_numbers.py. Please have a look and let me how if something can be improved. Quick question - I have not deleted "notebook/prompt_numbers.js" with this change, should I do it so anyone else does not spend time doing it again ?