Skip to content

Conversation

@takluyver
Copy link
Member

Bug found during pair programming with @mpacer

@takluyver takluyver added this to the 5.5 milestone Mar 9, 2018
@mpacer mpacer mentioned this pull request Mar 9, 2018
@takluyver
Copy link
Member Author

To elaborate a bit, the bug manifests when you click into a subdirectory from the tree view, and then use the back button to return to the first view that was loaded. The history entry for this has an empty state object, but that's still truthy in Javascript, so it was taking .path from it, which was undefined.

While fixing this, we realised that the fallback was also to the server root directory instead of the first directory loaded - they're normally the same, but don't have to be. So that is also fixed.

@takluyver
Copy link
Member Author

I'll merge this tomorrow unless anyone wants more time to review it.

@takluyver takluyver merged commit 276474a into jupyter:master Mar 15, 2018
@takluyver takluyver deleted the notebooklist-back-to-start branch March 15, 2018 14:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant