Limit length of GUI autocomplete to 1000 #3195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks. We also introduced a limit in IPython - see ipython/ipython#10743 - but I think the new Jedi completions might not be affected by that. |
Member
|
I've marked this as for 5.4, as we're just about to release notebook 5.3. |
Author
|
@takluyver is there anything else I need to do to get this merged? |
Member
|
No, I think this makes sense as is. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an object's dir() call returns a long list (greater than a few thousand), the UI locks up while it is creating this long list of elements. This just limits the maximum length to 1000 elements.