Skip to content

Conversation

@Naereen
Copy link
Contributor

@Naereen Naereen commented Jan 9, 2018

See #3193

@gnestor gnestor added this to the 5.3 milestone Jan 9, 2018
@gnestor gnestor merged commit de92a2b into jupyter:master Jan 9, 2018
@Naereen
Copy link
Contributor Author

Naereen commented Jan 19, 2018

(I am simply curious)
@gnestor how does the "Credits" list of people who contributed is generated for blog posts like this one ?

@takluyver
Copy link
Member

Sorry, you should have been in that list. I think it was copied from the changelog in the docs. You are listed in that version, but I added you just before the final release; I guess the blog post was written as a draft before that, and published without being updated.

As for how it's generated, @gnestor can probably give you more detail, but I expect it's based on git log and some amount of manual cleanup.

@Naereen
Copy link
Contributor Author

Naereen commented Jan 19, 2018

@takluyver no I honestly don't care, I was simply curious of the ratio between automated and manual tasks in this step 😃

@takluyver
Copy link
Member

I'm now interested to know that as well. Min's ghpro tool can get a list of authors automatically from Git and Github, but I don't think it adds the Github usernames automatically.

@gnestor
Copy link
Contributor

gnestor commented Jan 19, 2018

There's a notebook for that!

https://gist.github.com/gnestor/ae2449547e35dc779f36dfb322ca6ca0

I query Github for all PRs marked with a milestone (e.g. "5.3") and format them in a markdown and RST list for easy copying into our docs/source/changelog.rst file, Github release description, Google Group announcement, and Medium blog post. I then get a unique list of contributors by picking the user field from each PR. @Naereen I'm sorry, it looks like this method left you out ☹️ I assume the user associated with a PR is the author, but maybe it's the user who merged the PR? Maybe that's the source of error? @takluyver Do you see any obvious error in this notebook?

@takluyver
Copy link
Member

I think you just updated the changelog before this PR was merged. I edited it manually just before doing the release to add the last few PRs that were merged.

@gnestor
Copy link
Contributor

gnestor commented Jan 19, 2018

Oh I see.... I just re-ran the notebook and now I see @Naereen 👍

@Naereen
Copy link
Contributor Author

Naereen commented Jan 20, 2018

Great 👍 i'll read the notebook with attention :-) !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants