Skip to content

warn_bad_name should not use global name #3160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
takluyver merged 1 commit into from
Dec 22, 2017
Merged

warn_bad_name should not use global name #3160

takluyver merged 1 commit into from
Dec 22, 2017

Conversation

@Sukneet
Copy link
Contributor

@Sukneet Sukneet commented Dec 21, 2017

warn_bad_name in get_name should use the local variable name_or_data not name

@Sukneet
warn_bad_name should not use global name
ca5e39a 
warn_bad_name in get_name should use the local variable name_or_data not name
@takluyver takluyver added this to the 5.3 milestone Dec 22, 2017
@takluyver takluyver merged commit 3857c92 into jupyter:master Dec 22, 2017
@takluyver
Copy link
Member

takluyver commented Dec 22, 2017

Thanks, good catch!

@pyup-bot pyup-bot mentioned this pull request Jan 28, 2018
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

status:resolved-locked

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

2 participants

@Sukneet @takluyver