Skip to content

fix save-script deprecation #3053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
takluyver merged 1 commit into from
Nov 17, 2017
Merged

fix save-script deprecation #3053

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix save-script deprecation 
when updating to traitlets API, required argument was omitted
  • Loading branch information
@minrk
minrk committed Nov 17, 2017
commit 1eb970074b1869a7936112c60adfad215c901b8c
4 changes: 3 additions & 1 deletion notebook/services/contents/filemanager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,9 @@ def _default_root_dir(self):
save_script = Bool(False, config=True, help='DEPRECATED, use post_save_hook. Will be removed in Notebook 5.0')

@observe('save_script')
def _update_save_script(self):
def _update_save_script(self, change):
if not change['new']:
return
self.log.warning("""
`--script` is deprecated and will be removed in notebook 5.0.

Expand Down