Add 'reason' field to JSON error responses #2958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the deprecation/removal of the `@json_errors` decorator, the `reason` field was not carried forward into the compatible replacement method `APIHandler.write_error`. This broke some client (tests) that relied on that field's presence. Fixes jupyter#2957.
Member
|
@kevin-bates looking back at the old decorator code before #2853, it set reason to |
Member
Author
|
@takluyver - yeah, that's probably the best approach. Change committed. |
Member
|
Thanks. I'll merge tomorrow if no-one says otherwise. |
gnestor
approved these changes
Oct 31, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the deprecation/removal of the
@json_errorsdecorator, thereasonfield was not carried forward into the compatible replacementmethod
APIHandler.write_error. This broke some client (tests) thatrelied on that field's presence.
Fixes #2957.