Skip to content

Rely on umask for default directory permissions #2924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
takluyver wants to merge 1 commit into from
Closed

Rely on umask for default directory permissions #2924

takluyver wants to merge 1 commit into from

Conversation

@takluyver
Copy link
Member

@takluyver takluyver commented Oct 11, 2017

Closes gh-2858

@minrk this feels somewhat unsatisfactory. The function I want to change is in ipython_genutils, but we're not making any changes there. So do we need to extract it to each package that uses it to make similar fixes?

@takluyver takluyver mentioned this pull request Oct 11, 2017
Closed
@blink1073
Copy link
Contributor

blink1073 commented Oct 11, 2017

This search shows that ipython itself is no longer using ipython_genutils outside of indent and dedent in the docs generator. Perhaps moving the functions to jupyter_core makes sense?

@blink1073
Copy link
Contributor

blink1073 commented Oct 11, 2017

To be clear: I mean copying the functions currently used in this repo to jupyter_core, releasing jupyter_core, and removing the dependency of this repo on ipython_genutils.

@takluyver
Copy link
Member Author

takluyver commented Oct 11, 2017

That's a good idea. jupyter_core probably makes reasonable sense as a place for this.

@takluyver takluyver mentioned this pull request Oct 11, 2017
Merged
@takluyver
Copy link
Member Author

takluyver commented Oct 11, 2017

jupyter/jupyter_core#113 would add it to jupyter_core.

@takluyver
Copy link
Member Author

takluyver commented Oct 31, 2017

Closing in favour of #3002.

@takluyver takluyver closed this Oct 31, 2017
@minrk minrk added this to the Reference milestone Jun 15, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

status:resolved-locked

Projects

None yet

Milestone

Reference

Development

Successfully merging this pull request may close these issues.

.ipynb_checkpoints doesn't respect umask

3 participants

@takluyver @blink1073 @minrk