Update error handling on APIHandlers #2853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of redirecting to human login page, which can have side effects
…or messages this is the standard tornado way to do it, and catches errors at the `prepare` stage, which method decorators do not
takluyver
approved these changes
Sep 21, 2017
Member
takluyver
left a comment
takluyver
left a comment
There was a problem hiding this comment.
This looks good to me. I'll leave it for a day or so in case others want to have a look.
This was referenced Oct 16, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of redirecting to login page, which doesn't make sense for API handlers
and can cause undesirable side effects when using custom login handlers as in JupyterHub
(Redirect to login url on mismatched oauth state jupyterhub/jupyterhub#1438).
@json_errorsdecorator withwrite_errormethodon
APIHandler, which is the natural and more robust place to implement custom error handling in Tornado.