Skip to content

Conversation

@minrk
Copy link
Member

@minrk minrk commented Mar 3, 2017

  • test adding tags separated by comma and space, including duplicate items
  • test that adding tags affects metadata
  • test that clicking X removes tags from metadata
  • test that clicking X removes tags from the toolbar

minrk added 3 commits March 3, 2017 09:03
rather than checking if it’s ‘real’, which prevents `$(el).click()` from working
@minrk minrk added this to the 5.0 milestone Mar 3, 2017
@minrk
Copy link
Member Author

minrk commented Mar 3, 2017

@vidartf when I right-click, the click() callback is not called. Do you see this? It doesn't seem right that the 'X' should be the only element on the page with this behavior, in any case (the add tags button next to it doesn't have this).

@vidartf
Copy link
Contributor

vidartf commented Mar 3, 2017

@minrk There has been some changes recently: https://discourse.wicg.io/t/new-event-for-non-primary-button-click/1527, maybe this is not important anymore.

@gnestor gnestor merged commit c4d2c1a into jupyter:master Mar 7, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants