Support underline and inverse in ANSI escape codes #2186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Parse underline and inverse in ANSI escape codes * Add CSS classes for same, using a subtle outline for inverse
takluyver
approved these changes
Feb 14, 2017
Member
takluyver
left a comment
takluyver
left a comment
There was a problem hiding this comment.
I briefly tested this and it appears to be working.
tools/tests/ANSI Test.ipynb
Outdated
| "source": [ | ||
| "print (\"This is normal text\")\n", | ||
| "print()\n", | ||
| "print (\"{ESC}01mThis is bold text\".format(**locals()))\n", |
Member
There was a problem hiding this comment.
Is it intentional that you don't reset the style between lines, so this actually generates:
- normal
- bold
- bold + underlined
- bold + underlined + inverse
Contributor
Author
There was a problem hiding this comment.
Nope, good catch. I've updated the test to reset.
Member
|
Great, thanks. This looks good to me. |
mgeier
added a commit
to mgeier/notebook
that referenced
this pull request
Oct 23, 2017
The "inverse" escape sequence was implemented in jupyter#2186, but not by actually inverting foreground and background.
mgeier
added a commit
to mgeier/notebook
that referenced
this pull request
Oct 23, 2017
The "inverse" escape sequence was implemented in jupyter#2186, but not by actually inverting foreground and background.
Merged
mgeier
added a commit
to mgeier/notebook
that referenced
this pull request
Nov 1, 2017
The "inverse" escape sequence was implemented in jupyter#2186, but not by actually inverting foreground and background.
gnestor
pushed a commit
that referenced
this pull request
Nov 1, 2017
* Invert inverse ANSI colors The "inverse" escape sequence was implemented in #2186, but not by actually inverting foreground and background. * ANSI colors: allow switching off underline and inverse * Add CSS classes ansi-default-inverse-fg and ...-bg
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was dumping output from cdiff into a notebook and noticed that its use of underline and inverse escape codes wasn't being reflected in the notebook output. A couple simple tweaks to the ANSI parsing and some added CSS classes and it now does.