Skip to content

[WIP] Toggle all line numbers, & persist config #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Carreau wants to merge 4 commits into from
Closed

[WIP] Toggle all line numbers, & persist config #1423

Carreau wants to merge 4 commits into from

Conversation

@Carreau
Copy link
Member

@Carreau Carreau commented May 3, 2016

Add 3 actions show all,hide all, toggle, expose toggle in the menu.

Persist state to nbconfig. Also improve the config so that config option set on Cell apply to MD/Code/Raw unless overwritten. By a more specific config.

Thus the line-numbering state is stored as:

{
  "Cell": { 
    "cm_config": {
      "lineNumbers": false
    }
  }
}

@Carreau Carreau force-pushed the toggle-line-numbers branch 2 times, most recently from 942050e to f6d9b0e Compare May 3, 2016 21:45
@Carreau
Inherit configuration and propagate it from MD cell
c040464 
Persist the configuration of toggling in nbconfig.
@Carreau Carreau force-pushed the toggle-line-numbers branch from f6d9b0e to c040464 Compare May 3, 2016 21:47
@Carreau
Copy link
Member Author

Carreau commented May 6, 2016

Nah, bug, it erase CodeCell.cm_config default options instead of merging them, leading to no syntax highlighting,

@Carreau Carreau mentioned this pull request May 6, 2016
Closed
@minrk minrk added this to the 5.0 milestone May 8, 2016
@Carreau Carreau self-assigned this Jun 4, 2016
@minrk minrk changed the title Toggle all line numbers, & persist config [WIP] Toggle all line numbers, & persist config Jul 25, 2016
@gnestor
Copy link
Contributor

gnestor commented Aug 11, 2016 •
edited
Loading

@Carreau It looks like #1312 is a continuation of this PR. If so, should we close this one?

@Carreau
Copy link
Member Author

Carreau commented Aug 12, 2016

Sure, let's close.

@Carreau
Copy link
Member Author

Carreau commented Aug 12, 2016 •
edited
Loading

Wait technically this one is the continuation of #1312 as this is the most recent one.
As you like.

@gnestor
Copy link
Contributor

gnestor commented Aug 12, 2016

Oh you're right! I basically reimplemented what you did in this PR! Ok, let me reconcile this and #1676...

@gnestor
Copy link
Contributor

gnestor commented Aug 17, 2016

Merged by #1676

@gnestor gnestor closed this Aug 17, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@Carreau Carreau

Labels

status:resolved-locked

Projects

None yet

Milestone

5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Carreau @gnestor @minrk @vivi