Merge pull request #3459 from takluyver/appveyor-path-fails

mpacer · web-flow · commit e433b81bcc64 · 2018-03-22T14:35:58.000-07:00
Undo patches in teardown before attempting to delete files
diff --git a/notebook/tests/launchnotebook.py b/notebook/tests/launchnotebook.py
@@ -178,9 +178,9 @@ def start_thread():
     def teardown_class(cls):
         cls.notebook.stop()
         cls.wait_until_dead()
-        cls.tmp_dir.cleanup()
         cls.env_patch.stop()
         cls.path_patch.stop()
+        cls.tmp_dir.cleanup()
         # cleanup global zmq Context, to ensure we aren't leaving dangling sockets
         def cleanup_zmq():
             zmq.Context.instance().term()
diff --git a/notebook/tree/tests/test_tree_handler.py b/notebook/tree/tests/test_tree_handler.py
@@ -4,6 +4,10 @@
 from notebook.utils import url_path_join
 from nbformat import write
 from nbformat.v4 import new_notebook
+try:
+    from urllib.parse import urlparse
+except ImportError:
+    from urlparse import urlparse
 
 import requests
 
@@ -28,5 +32,7 @@ def test_redirect(self):
         r = self.request('GET', 'tree/foo/bar.ipynb')
         self.assertEqual(r.url, self.base_url() + 'notebooks/foo/bar.ipynb')
 
-        r = self.request('GET', 'tree/foo/baz.txt')
-        self.assertEqual(r.url, url_path_join(self.base_url(), 'files/foo/baz.txt'))
+        r = self.request('GET', 'tree/foo/baz.txt', allow_redirects=False)
+        self.assertEqual(r.status_code, 302)
+        self.assertEqual(r.headers['Location'],
+             urlparse(url_path_join(self.base_url(), 'files/foo/baz.txt')).path)
