Skip to content

Commit cf4341a

Browse files
committed
Merge pull request #242 from minrk/hardcode-widgets-js
load widget extension in js
2 parents 0afe9d2 + ff191ae commit cf4341a

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

notebook/static/base/js/utils.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -842,6 +842,7 @@ define([
842842
};
843843

844844
var utils = {
845+
load_extension: load_extension,
845846
load_extensions: load_extensions,
846847
load_extensions_from_config: load_extensions_from_config,
847848
regex_split : regex_split,

notebook/static/notebook/js/main.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,8 @@ require([
5151
"use strict";
5252

5353
// BEGIN HARDCODED WIDGETS HACK
54-
// Don't include in above require call, avoiding r.js
55-
// and crash on import failure.
56-
require(['nbextensions/widgets/notebook/js/extension'], function(){}, function(err) {
57-
console.error('ipywidgets package not installed. Widgets are not available.');
54+
utils.load_extension('widgets/notebook/js/extension').catch(function () {
55+
console.warn('ipywidgets package not installed. Widgets are not available.');
5856
});
5957
// END HARDCODED WIDGETS HACK
6058

0 commit comments

Comments
 (0)