Merge pull request #2851 from minrk/fix-image-tests

rgbkrk · web-flow · commit 2d582e0e796e · 2017-09-19T11:09:51.000-07:00
avoid base64-literals in image tests
diff --git a/notebook/tests/notebook/roundtrip.js b/notebook/tests/notebook/roundtrip.js
@@ -150,6 +150,13 @@ casper.notebook_test(function () {
         check_output_area.apply(this, ['execute_result', ['text', 'html']]);
     });
 
+    this.then(function() {
+        clear_and_execute(this,
+            "from base64 import b64decode;" + 
+            "black_dot_png = b64decode(" + black_dot_png + ");" + 
+            "black_dot_jpeg = b64decode(" + black_dot_jpeg + ")"
+        );
+    });
     this.then(function() {
         clear_and_execute(this,
             "from IPython.display import HTML, display; display(HTML('<b>it works!</b>'))");
@@ -162,7 +169,7 @@ casper.notebook_test(function () {
 
     this.then(function() {
         clear_and_execute(this,
-            "from IPython.display import Image; Image(" + black_dot_png + ")");
+            "from IPython.display import Image; Image(black_dot_png)");
     });
     this.thenEvaluate(function() { IPython.notebook.save_notebook(); });
     
@@ -172,7 +179,7 @@ casper.notebook_test(function () {
     
     this.then(function() {
         clear_and_execute(this,
-            "from IPython.display import Image, display; display(Image(" + black_dot_png + "))");
+            "from IPython.display import Image, display; display(Image(black_dot_png))");
     });
     
     this.then(function ( ) {
@@ -182,7 +189,7 @@ casper.notebook_test(function () {
 
     this.then(function() {
         clear_and_execute(this,
-            "from IPython.display import Image; Image(" + black_dot_jpeg + ", format='jpeg')");
+            "from IPython.display import Image; Image(black_dot_jpeg, format='jpeg')");
     });
     
     this.then(function ( ) {
@@ -191,7 +198,7 @@ casper.notebook_test(function () {
     
     this.then(function() {
         clear_and_execute(this,
-            "from IPython.display import Image, display; display(Image(" + black_dot_jpeg + ", format='jpeg'))");
+            "from IPython.display import Image, display; display(Image(black_dot_jpeg, format='jpeg'))");
     });
     
     this.then(function ( ) {
