Merge pull request #2421 from minrk/allow-root-after-super

takluyver · web-flow · commit 28d5454d37d9 · 2017-04-19T12:57:18.000+01:00
check allow_root after calling super
diff --git a/notebook/notebookapp.py b/notebook/notebookapp.py
@@ -1388,6 +1388,8 @@ def start(self):
         This method takes no arguments so all configuration and initialization
         must be done prior to calling this method."""
 
+        super(NotebookApp, self).start()
+
         if not self.allow_root:
             # check if we are running as root, and abort if it's not allowed
             try:
@@ -1398,8 +1400,6 @@ def start(self):
                 self.log.critical("Running as root is not recommended. Use --allow-root to bypass.")
                 self.exit(1)
 
-        super(NotebookApp, self).start()
-
         info = self.log.info
         for line in self.notebook_info().split("\n"):
             info(line)
