Automatically add execution context to Rails.error.context#27
Merged
Conversation
|
|
skatkov
force-pushed
the
rails-error-context
branch
from
edee630 to
309a6f4
Compare
skatkov
force-pushed
the
rails-error-context
branch
from
309a6f4 to
50cfb84
Compare
julik
reviewed
May 15, 2026
| { | ||
| workflow_id: workflow.id, | ||
| workflow_class: workflow.class.name, | ||
| step_execution_id: step_execution.id, |
Owner
There was a problem hiding this comment.
Is this always set? I remember there being a few cases where the step_execution is not yet retrieved, but an error already gets reported. Can you check this and if needed add a test? this may need a &
Contributor
Author
There was a problem hiding this comment.
error_context is only called after @step_execution has been assigned. All internal Rails.error.report paths also happen after the executor has entered call.
We can, of course, add & defensively. But with the current flow of things, I would say it's not required.
Owner
There was a problem hiding this comment.
ok let me and my roborains take a quick look
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.