Skip to content

Conversation

@umbreak
Copy link
Contributor

@umbreak umbreak commented Feb 28, 2021

Added support for Json literal

I've added the tests from the current test suite related to JSON literal. The only test that doesn't pass (which I remove from the manifest) is toRdf-js12. An unicode code point \u00F is meant to be lowercased to \u00f.

@coveralls
Copy link

coveralls commented Feb 28, 2021

Coverage Status

Coverage increased (+0.5%) to 90.055% when pulling 330c158 on umbreak:jsonld-11-type-json into 506d761 on jsonld-java:master.

@dr0i
Copy link
Member

dr0i commented Mar 1, 2021

Hi @umbreak , I don't know if your are aware of #283, also #284 (comment). I think there are some redundancies to ypur PR.
I don't know how, or if, we proceed on this.

@umbreak
Copy link
Contributor Author

umbreak commented Mar 1, 2021

The branch you are referring me to is an attempt to fully support of 1.1. I was hoping for a more iterative approach here where only some features are introduced (in order to not be stuck).

But I understand if you don't see it the same way.

@fsteeg
Copy link
Member

fsteeg commented Mar 2, 2021

The branch you are referring me to is an attempt to fully support of 1.1. I was hoping for a more iterative approach here where only some features are introduced

This was exactly my intention with that setup, see #277 (comment):

I think that with this setup, we can keep releasing from master whenever the build passes, while making available the 1.1 support that we currently have.

Maybe we should follow up on the suggestion by @ansell in #283 (comment) and merge #283 into develop, and move on from there (e.g. rebasing this on develop).

@umbreak
Copy link
Contributor Author

umbreak commented Mar 2, 2021

I'm fine with that approach too. Once you merge #283 into develop branch I can put this functionality in that branch.

@dr0i
Copy link
Member

dr0i commented Mar 4, 2021

I merged #283 into the develop branch.
@umbreak as you proposed, you may go on and put the functionality into a PR against that develop branch.

@umbreak
Copy link
Contributor Author

umbreak commented Mar 23, 2021

Done in the develop branch

@umbreak umbreak closed this Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants